[19.0][MIG] supplier_calendar: Migration to 19.0#3053
Merged
Conversation
Fix pre-commit errors by addind the correct `website` key
Currently translated at 100.0% (8 of 8 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-supplier_calendar Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-supplier_calendar/it/
Currently translated at 100.0% (8 of 8 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-supplier_calendar Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-supplier_calendar/es/
when delta argument is a float `plan_days` method can return unexpected False result. This can lead to silent errors. Therefore we ensure that delta is a integer in the helper.
78 tasks
cyrilmanuel
approved these changes
May 5, 2026
Contributor
cgarcia-solvos
left a comment
cgarcia-solvos
left a comment
There was a problem hiding this comment.
Code review. LGTM. Only minor comment:
BhaveshHeliconia
force-pushed
the
19.0-mig-supplier_calendar
branch
from
dfefe30 to
701a7d9
Compare
cgarcia-solvos
approved these changes
May 18, 2026
HviorForgeFlow
approved these changes
May 19, 2026
Member
|
/ocabot merge nobump |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at afe6977. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.